Closed Yutong-Dai closed 2 years ago
You're right that the iterations are 0-indexed, but so are all the arrays probs
, succs
and queries
. Namely, probs[:, 0]
contains the model's predicted probabilities at the first iteration (iteration 0). Does this make sense?
Thanks for your nice code.
I am wondering if there's a potential bug in the simba.py. Specifically, starting from line 107 to line 109.
My observation is as follows.
succs[:, k]
is all zeros. In contrast, I expect it to be a all-1 tensor.The proposed fix is as follows.
This will address the concern, but it still looks weird.
Since I tested on my own trained model, so I do not provide the minimal reproducible code. But if you would like me to provide one, please let me know.
Thanks in advance.