search

cga-harvard / Hypermap-Registry

Hypermap Registry, remote map services made easy for your SDI
https://cga-harvard.github.io/Hypermap-Registry/
MIT License
38 stars 21 forks source link

Sanitize URL for services #242

Open capooti opened 7 years ago

capooti commented 7 years ago

There are many cases where url for endpoints should be sanitized.

For example this url for a WMS: http://tepeserwery.pl/tileservice/wms.php/icrsptixwh?SERVICE=WMS&VERSION=1.1.1&REQUEST=GetCapabilities

should be sanitized to: http://tepeserwery.pl/tileservice/wms.php/icrsptixwh?

Otherwise MapProxy will not work properly as there will be both a GetCapabilities and a GetMap in the request.

There are complex case to keep in account such as: http://host/mywms?map=foo.map

tomkralidis commented 7 years ago

As discussed this will be fixed in OWSLib.

tomkralidis commented 7 years ago

FYI this is been implemented in OWSLib (master branch), so that OWSLib classes will take care of cleaning the URL when invoked/initiated.

capooti commented 7 years ago

great! When are you planning a release?

tomkralidis commented 7 years ago

Next couple of weeks. Feel free to remind if things drag on past that.

capooti commented 7 years ago

Excellent. @lordofhogwarts when @tomkralidis make the release could you bump it to requirements.txt?

blewis commented 7 years ago

Thanks Tom!