search

cgarciae / treex

A Pytree Module system for Deep Learning in JAX
https://cgarciae.github.io/treex/
MIT License
214 stars 17 forks source link

Feature/metrics #17

Closed anvelezec closed 2 years ago

anvelezec commented 3 years ago

This pull request has the implementation of mean absolute error, as well as some unit test cases.

cgarciae commented 3 years ago

@anvelezec please rebase :)

cgarciae commented 3 years ago

@anvelezec would be cool if we could do more exhaustive tests using hypothesis like the one in here:

https://github.com/cgarciae/treex/blob/3fa742166b12cb808aa33c1df7b0b159093c6209/tests/losses/crossentropy_test.py#L21

cgarciae commented 2 years ago

@anvelezec can you accept the suggested changes? This PR is good to go.