cgarciae / treex

A Pytree Module system for Deep Learning in JAX
https://cgarciae.github.io/treex/
MIT License
215 stars 17 forks source link

MeanSquaredError and MeanAbsoluteError Metrics use old argument names #55

Closed cgarciae closed 2 years ago

cgarciae commented 2 years ago

Since recently we've been using the following convention for the arguments for Metric's update function:

However, MeanSquareError and MeanAbsoluteError use the old convention:

https://github.com/cgarciae/treex/blob/3aa54154e8a28dc25aba7dd79bac3b0c7e56e1ba/treex/metrics/mean_square_error.py#L64-L69 https://github.com/cgarciae/treex/blob/3aa54154e8a28dc25aba7dd79bac3b0c7e56e1ba/treex/metrics/mean_absolute_error.py#L64-L69

This is not a hard issue for Treex itself but Elegy does rely on this convention and it makes these metrics incompatible (poets-ai/elegy#216).

cc: @anvelezec @jmarrietar