search

cgarling / StarFormationHistories.jl

Fitting astrophysical star formation histories via CMD modelling.
MIT License
4 stars 0 forks source link

Overhaul of binary model API and addition of module tests #15

Closed cgarling closed 1 year ago

cgarling commented 1 year ago

To add BinaryMassRatios required an overhaul of the binary sampling API in simulate.jl. This was implemented with relevant documentation as well. Module tests have also been added for methods considered reasonably stable.

We also moved away from the luminosity utilities (i.e. MV_from_L) to flux utilities which are now mag2flux and flux2mag mirroring the IDL Astronomy User's Library. Analogous functions are available in AstroLib.jl but these functions will promote Float32 arguments which I find undesirable, so I chose to write alternate versions here.

I have rerun my active science analyses with these updates and all seem to support this update.

cgarling commented 1 year ago

I also moved some old tests to test/_oldtests.jl that do not work with or / are not useful for the new APIs. I'm keeping them around because they may be useful in the future though this is not generally a good practice ....