cgarry / ser-player

A simple video player for playing SER files used for solar, lunar and planetary astronomy-imaging.
https://sites.google.com/site/astropipp/ser-player
GNU General Public License v3.0
49 stars 15 forks source link

Help diagnose issue with INDI produced SER files #8

Open knro opened 3 years ago

knro commented 3 years ago

So this is probably not an issue with the SER player itself, but I would appreciate any insight it finding why 16bit RGGB bayered frames aren't displayed correctly in the SER player. Unfortunately, the only 16bit Touptek camera I have here cannot reach focus so I can't share clear images, but for this purpose it's quite sufficient.

When the images are streaming to KStars, they're displayed correctly. Of course, INDI downsamples them to 8bit, so this could be why they show up as fine.

Screenshot_20201106_205215

However, this 2-frame file looks like an RGB mess in the SER player:

https://www.dropbox.com/s/bd13lbtoyxuqo5w/indi_record_2020-11-06%4016-44-32.ser?dl=0

I doubled checked the INDI driver and it appears everything is in order. Endianess is fine, header is OK, data appears to be fine. So any clue what's wrong exactly?

cgarry commented 3 years ago

The LittleEndian field in the SER header is always incorrect. I initially coded SER player to work as the spec says it should, but I found that EVERY other program did it the other way. So I simply fell into line and changed SER player to do it the 'wrong' way. Could this be the difference?

Can you correctly display the attached SER file? This was sent to me many years ago as a golden file.

Cheers, Chris

On Fri, 6 Nov 2020 at 18:06, Jasem Mutlaq notifications@github.com wrote:

So this is probably not an issue with the SER player itself, but I would appreciate any insight it finding why 16bit RGGB bayered frames aren't displayed correctly in the SER player. Unfortunately, the only 16bit Touptek camera I have here cannot reach focus so I can't share clear images, but for this purpose it's quite sufficient.

When the images are streaming to KStars, they're displayed correctly. Of course, INDI downsamples them to 8bit, so this could be why they show up as fine.

[image: Screenshot_20201106_205215] https://user-images.githubusercontent.com/5986347/98398870-b16cf300-2072-11eb-90af-74dd9269e7fe.jpg

However, this 2-frame file looks like an RGB mess in the SER player:

https://www.dropbox.com/s/bd13lbtoyxuqo5w/indi_record_2020-11-06%4016-44-32.ser?dl=0

I doubled checked the INDI driver and it appears everything is in order. Endianess is fine, header is OK, data appears to be fine. So any clue what's wrong exactly?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cgarry/ser-player/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCDVYIKAH2K365SXD3TOFLSOQ3J5ANCNFSM4TM7K4ZA .

knro commented 3 years ago

Thanks, so I don't see any attachments since this is a Github issue.

cgarry commented 3 years ago

Good point! Try this dropbox link:

https://www.dropbox.com/s/tvc39ls4m9v5jtv/SER_BGR_16bit_LittleEndian_397_397.zip?dl=0

On Fri, 6 Nov 2020 at 18:29, Jasem Mutlaq notifications@github.com wrote:

Thanks, so I don't see any attachments since this is a Github issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cgarry/ser-player/issues/8#issuecomment-723232949, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCDVYJCZULFK5F7WK4UDDLSOQ6AFANCNFSM4TM7K4ZA .

knro commented 3 years ago

So you're right! I set it BIG_ENDIAN and it worked! So you're saying this is consistent among all astro-processing software?