search

cgarvis / angular-toggle-switch

AngularJS Toggle Switch
http://cgarvis.github.io/angular-toggle-switch
MIT License
160 stars 124 forks source link

Added knobLabel, made bindings optional, bumped angularjs version to 1.2. #6

Closed Hypercubed closed 11 years ago

cgarvis commented 11 years ago

Please don't submit pull requests on top of someone else's pull request. Makes it impossible to merge this without merging the other.

cgarvis commented 11 years ago

What is the point of knobLabel?

Hypercubed commented 11 years ago

Yes, sorry. I thought it was strange to fork off a fork of a fork then submit a pull request but my changes made no sense without with they previous forks. I can redo if needed.

The knobLabel (defaulting to   fills the area between on and off. In bootstrap switch it's called text-label. http://www.bootstrap-switch.org/#label-text

cgarvis commented 11 years ago

Cool. Can you create a new PR with just the knobLabel? I fixed the optional binding and the no assign errors.