search

cgarvis / angular-toggle-switch

AngularJS Toggle Switch
http://cgarvis.github.io/angular-toggle-switch
MIT License
160 stars 124 forks source link

Ng disabled bug #81

Closed zachlysobey closed 7 years ago

zachlysobey commented 9 years ago

This fixes some of the issues from Issue https://github.com/cgarvis/angular-toggle-switch/issues/80, including making the failing tests pass.

Unfortunately, it seems to break some other 'disabled' functionality, so maybe this isn't really appropriate to merge in just yet.

I started trying to write some tests to confirm the bugs, but got a little stuck. I added stubs for test changes with @TODOs to this PR as well.

I'd be happy to put a little more work into this, but probably won't be able to for another couple weeks.

Feel free to do with this what you will, and/or suggest other ways I might be of service.

zachlysobey commented 9 years ago

Here's a plunker with my version of the .js. This should illustrate the remaining issues. http://plnkr.co/edit/aKn8BtpzASKnowJred5e?p=preview

Compare this to the plunker with your code from Issue https://github.com/cgarvis/angular-toggle-switch/issues/80 http://plnkr.co/edit/YtlRjooAZiiv0uAN3a5G?p=preview

aasukisuki commented 9 years ago

+1

zachlysobey commented 7 years ago

I'm closing this b/c its not getting any attention, and I'm not an angular guy anymore. Feel free to re-open