Closed geeto1969 closed 4 years ago
I reached out to the Fully Kiosk developer and found that the API changed in version code 784, so we should add a version check self.coordinator.data["appVersionCode"]
< 784 use the old keys, otherwise use the new keys
I reached out to the Fully Kiosk developer and found that the API changed in version code 784, so we should add a version check
self.coordinator.data["appVersionCode"]
< 784 use the old keys, otherwise use the new keys
Thanks for this information. I'll update my contribution to include this check. Unfortunately, I don't have an older version of Fully Kiosk to use for validation. After this fix, I may look at dealing with API updates generally.
Added check for appVersionCode.
Noticed a number of other issues related to similar resources accessed through cmd=deviceInfo
, the command used by python-fullykiosk, and cmd=getDeviceInfo
, the command currently specified in the Fully Kiosk API documentation. Using cmd=getDeviceInfo
will return versionCode
instead of appVersionCode
. This will break the fix if python-fullykiosk is updated in the future to use the most current API.
Yeah, the cmd=getDeviceInfo
was added around the same time, supposed to unify the api data between REST and MQTT. We'll want to switch to using that eventually
PR looks good, thanks!
Screensaver key should be 'isInScreensaver' Screen on key should be 'screenOn'
The following errors are observed with Fully Kiosk App v1.40.3 and v1.42.2, possibly due to an API update in the app: