Closed kpine closed 4 years ago
Can you provide me with a mqtt dump please so I can test this ?
Sure, but the problem is the discovery schema. Compare the one here vs. HA core.
Sure, but the problem is the discovery schema. Compare the one here vs. HA core.
May be true but I'd still like to receive the dump ;-)
You're too fast! Here it is.
Thanks, this will allow me to reproduce as I do not own climate devices.
Ah, I guess that was added to the core zwave after this project was initiated ;-)
I think that's true. I should have remembered to mention it before.
Also, this core issue should be fixed: https://github.com/home-assistant/core/issues/30180
I think that's true. I should have remembered to mention it before.
Also, this core issue should be fixed: home-assistant/core#30180
I'd rather focus on getting this project stable but feel free to submit a PR for that specific issue.
@marcelveldt Do you still need a mqtt dump from me also? Thanks to @kpine for opening this issue.
@marcelveldt Do you still need a mqtt dump from me also? Thanks to @kpine for opening this issue.
If you own a different thermostat than kpine: yes please
I'd rather focus on getting this project stable but feel free to submit a PR for that specific issue.
Instead, I should have said, please don't break those thermostat types when fixing this, because they aren't broken here yet.
I'd rather focus on getting this project stable but feel free to submit a PR for that specific issue.
Instead, I should have said, please don't break those thermostat types when fixing this, because they aren't broken here yet.
Haha, true. Let's try to make this version a lot better!
Ah yeah, the climate change in the current core
component came after I copied the discovery schema's over to this project and this project was never updated to include them. I had actually forgotten about that until now.
Ah yeah, the climate change in the current
core
component came after I copied the discovery schema's over to this project and this project was never updated to include them. I had actually forgotten about that until now.
No problem, I'm working through it now. Unfortunately it wasn't as easy as copying the discovery schema.
@marcelveldt Here you go! Please let me know what else I can do to help with this :-)
Im also seeing this.
https://gofile.io/?c=rrUiJ2
@marcelveldt I just pulled down the master using HACS and I'm not seeing any change, I still have two climate entities. I removed and readded the integration and no change. Anything I can do to help troubleshoot?
@marcelveldt I just pulled down the master using HACS and I'm not seeing any change, I still have two climate entities. I removed and readded the integration and no change. Anything I can do to help troubleshoot?
No, just have some patience ;-)
No, just have some patience ;-)
Sorry, I'll be patient!
I just published version .15 to HACS, please have a test with that. As we're already implementing the code into core Hass it would be great to get some feedback if this issue is resolved.
WARNING: version .15 contained a change to the internal id matching so it is normal that you need to rename your entities/devices again.
Looks good to me. My CT32 with thermostat mode has a single climate entity now.
There is something wrong with the preset behavior though, but I need to look more. Will log that separately if it turns out to be an issue.
As the originally reported issue is resolved, I'll close this issue. The climate platform will be merged to the core implementation with these adjustments included.
This issue will be fixed in the core implementation so please keep an eye on the next beta version of Home Assistant. Thanks for your help testing and reporting the issue.
My thermostat which supports COMMAND_CLASS_THERMOSTAT_MODE has 4 separate climate entities, one for each setpoint. These should be combined into a single climate entity, as is done in HA core Z-Wave.