cgarwood / homeassistant-zwave_mqtt

Limited Pre-Release of the new OZW1.6 Z-Wave component. Currently has limited platform support. Check the README for more details.
72 stars 8 forks source link

Add services #15

Open cgarwood opened 4 years ago

cgarwood commented 4 years ago

Add services for various OpenZWave functions.

Unlike the current zwave component implementation of these services, we'll need to also allow specifying an OZW Instance number since multiple OZW instances can be running and reporting to MQTT. We should default the OZW Instance to be instance 1 though, for compatibility.

May require upstream modifications to the python-openzwave-mqtt library

marcelveldt commented 4 years ago

completed:

add_node (with secure param) remove_node cancel_command set_config_parameter remove_failed_node replace_failed_node

to do:

refresh_node_value refresh_node refresh_entity heal_network set_wakeup reset_node_meters heal_node test_node set_poll_intensity change_association set_node_value print_config_parameter print_node

marcelveldt commented 4 years ago

set_config_parameter should probably be reviewed to make it a bit more user friendly. now the only possibility is to set a value by index and value_id.

We can also add support for setting a value by name and label, which is a bit more user friendly.

cgarwood commented 4 years ago

I think we can leave the following services in the to-do list out, as they can be handled through the OZW admin tools if needed, and should be websocket commands when we build the new management UI in HA: heal_network set_wakeup heal_node test_node set_poll_intensity change_association set_node_value print_config_parameter print_node

That would leave the following on the todo list: refresh_node_value refresh_node refresh_entity reset_node_meters

kpine commented 4 years ago

FYI, none of the network commands are implemented in OZW Admin yet.

uSpike commented 4 years ago

set_config_parameter was added here, but not in the core component. I would find that particularly useful for automating a few devices, such as changing the default brightness of lights. I'm wondering what needs to be done to bring that particular service over? Should that be discussed here or as a core issue? I'd be happy to open an issue and get that discussion started there.

marcelveldt commented 4 years ago

I think many people use that feature. It will be added, on our todo list.