search

cgarwood / homeassistant-zwave_mqtt

Limited Pre-Release of the new OZW1.6 Z-Wave component. Currently has limited platform support. Check the README for more details.
72 stars 8 forks source link

Add support for services #35

Closed marcelveldt closed 4 years ago

marcelveldt commented 4 years ago

Add (basic) support for services, to be extended later on.

I've decided to move the services stuff into a separate file/class for code hygiene/readability reasons, in the old implementation this was all packed into the config_flow method which is horror to read/follow.

marcelveldt commented 4 years ago

All fixed. No idea where the linter in Travis is angry about. Both flake8 and pylinter are happy on my setup with default PEP8 style conventions enabled.

balloob commented 4 years ago

Both isort and black are not satisfied: https://travis-ci.com/cgarwood/homeassistant-zwave_mqtt/builds/145290764

Locally run pip install pre-commit and then pre-commit install and it will fix it for you when making commits 👍

For now manually run isort and black on the files and commit changes.

balloob commented 4 years ago

btw for Travis, you can click on "Details" and then click on "The Build"

balloob commented 4 years ago

Are you on Discord? Let's connect there.