cgarwood / homeassistant-zwave_mqtt

Limited Pre-Release of the new OZW1.6 Z-Wave component. Currently has limited platform support. Check the README for more details.
72 stars 8 forks source link

Add cover support #78

Closed steinerl closed 4 years ago

steinerl commented 4 years ago

Hello,

this implementation includes a generic cover class and a specific class for the Fibaro FGRM-222 device to support the "Venetian blind"/tilt mode.

Currently, the decision whether to use the FibaroFGRM222Cover class or not is solely based on the MANUFACTURER_ID and PRODUCT_TYPE. In the future, the decision should also be made based on the configuration (Venetian blind mode active), once the python-openzwave-mqtt library properly supports list values (see cgarwood/python-openzwave-mqtt#53).

A few limitations of this implementation currently:

Fixes #9

marcelveldt commented 4 years ago

Thanks for your help! Code looks fine to me, assuming you took the existing hass implementation as example ?

steinerl commented 4 years ago

Yes, I took the existing Z-Wave component as an example, but I only implemented the parts that I was able to test - hence no implementation for the garage door devices.

marcelveldt commented 4 years ago

sounds familiar, I had the same thing when implementing lights support as I only own dimmers and not (rgb) bulbs.

MartinHjelmare commented 4 years ago

I think we can merge this.