search

cgarwood / homeassistant-zwave_mqtt

Limited Pre-Release of the new OZW1.6 Z-Wave component. Currently has limited platform support. Check the README for more details.
72 stars 8 forks source link

Handle restarts and removals #93

Closed marcelveldt closed 4 years ago

marcelveldt commented 4 years ago

The announced PR that will make thing a bit more robust, especially to handle OZW being offline/restarting and such. The integration will now be able to survive that.

Also fixes the usecase where a Z-Wave node actually get removed from the mesh and entities/devices need to be cleanup up in hass.

marcelveldt commented 4 years ago

@MartinHjelmare @cgarwood okay to merge this one ?

marcelveldt commented 4 years ago

Great!

Thanks for reviewing again!

MartinHjelmare commented 4 years ago

Will this close any issues?

marcelveldt commented 4 years ago

This will close #24 and #25 and #18

MartinHjelmare commented 4 years ago

This one too? https://github.com/cgarwood/homeassistant-zwave_mqtt/issues/68

marcelveldt commented 4 years ago

This one too?

68

No a PR for that one is coming up

MartinHjelmare commented 4 years ago

Will this really solve the last will status in #24?

marcelveldt commented 4 years ago

Will this really solve the last will status in #24?

Sort of, it now listens to the status of OZW which is already a huge improvement. The pro solution would be to also keep taps on the MQTT connection itself and track the LWT of the OZW daemon to MQTT. Foundation is now in place to improve that if we really want.

MartinHjelmare commented 4 years ago

Sorry, the last will thing was mentioned in #25.

Sounds good!

MartinHjelmare commented 4 years ago

Go ahead and merge here, at will! Nice job!

marcelveldt commented 4 years ago

Go ahead and merge here, at will! Nice job!

Great, thanks for your assistance. Great way to get familiar with core code.