New install on MantisBT 1.2.17 -> bug fixes?

[charleslales]

Hi,

Just made a fresh install from master with MantisBT 1.2.17 on WAMP server 2.4 (Apache 2.4.4, PHP 5.4.16, MySQL 5.6.12).

Here at the modifications or even bug fixes I had to do. Can you tell me if it is alright or advise me smthg else?

By the way, thanks a lot for such great job! Exactly what I were looking for as visual agile overlay on Mantis!

Kind regards, Charles

index.js

l.646, cosmetic log("Local settings exists!!!"); instead of log("Local story exists!!!");

soapclient.js

l.205, bug fix var nd = SOAPClient._getElementsByTagName(req.responseXML, method + "Response"); instead of var nd = SOAPClient._getElementsByTagName(req.responseXML, method + "Result");

l.221 - 223, bug fix

if(callback) callback((o.return?o.return:o), req.responseXML); if(!async) return (o.return?o.return:o);

instead of

if(callback) callback(o, req.responseXML); if(!async) return o;

l.355, is it cross-browser compatible? return document.selectNodes(".//*[local-name()=\""+ tagName +"\"]"); c.f. http://www.w3schools.com/xpath/xpath_examples.asp IE: xmlDoc.selectNodes(xpath); Firefox, Chrome, Opera and Safari: xmlDoc.evaluate(xpath, xmlDoc, null, XPathResult.ANY_TYPE,null);

And on the Mantis side, \library\nusoap\nusoap.php l.6132, had to comment following debug line.. is it normal? //$this->debug("serializing array element: $k, $v of type: $typeDef[arrayType]");

[cgaspard]

HI @charleslales ,

I've incorporated most of your fixes into the dev branch for testing. I'll load it up on my server and spend some time to make sure nothing else brakes.

I haven't incorporated the last two issues you sent.

The xpath one, I haven't experienced any cross browser issues, but I generally test on the latest FF, IE, Chrome and Safari. So it may be able to fix problems with previous versions. If you can confirm that it does this, I'll gladly include it.

The last issue with mantis itself, I haven't seen anything like that before. I generally stay away with trying to fix mantis itself, and just focus on working around any issues in their latest release. Can you confirm that this was breaking something for you in particular? I haven't loaded 1.2.17 yet.

I appreciate you sending these in.

Corey

[charleslales]

Hi,

Really impressed by your reactivity! And thx for taking into account these fixes.

For this one, l.221 - 223, could you explain why there is now this field .return comming in the SOAP answer from Mantis..? if(callback) callback((o.return?o.return:o), req.responseXML); if(!async) return (o.return?o.return:o);

For the cross-browser compatibility l.355, I don't have here my dev env, and it wasn't a bug but just a guess at one moment put me one this line. Why do you do a selectNodes instead of the following call in case of failure..? Is it a perf interest?

The last issue it wasn't for fun that I touch Mantis.. This fix (or sort of) is based on a post on a forum, prob. the Mantis one.

Since I don't have a php debuger activated, I were not able to clearly identified what was wrong on this line and moreover if it was coming from mantiskanban :-o

By the way, I will soon try to integrate mantiskanban in SharePoint, thx to an editor webpart for the ones who knows this plateform. The fact is already in the html page example has 4 form nodes.. and this is not so suitable :-/ Another point: the css may have some options that the mantiskanban take over 100% of the page content width.. and I'm not so at ease with css..

Kind regards, Charles

[charleslales]

Hi,

I may have a compatibility issue with IE8.. and numerous get/set in the code. https://developer.mozilla.org/en/JavaScript/Reference/Operators/Special/get

The following code will trigger a syntax error. var human = function() { var _firstName = ''; return { get firstName() { return _firstName; }, set firstName(name) { _firstName = name; } } }(); human.firstName = 'Charles'; alert(human.firstName);

A solution could be to update as follow: var human = function() { var _firstName = ''; return { firstName: function() { if (arguments.length === 1) { _firstName = arguments[0]; } else { return _firstName; } } }; }(); human.firstName('Charles'); alert(human.firstName());

But it is not nice.. Would you have another solution / way to undle retro compatibility with IE8..? How is doing then jQuery?

Kind regards, Charles

[cgaspard]

Hi Charles,

As of now I don't plan on supporting IE8. Future versions of IE, IE9 and up, handle setters and getters like other browsers.

Corey

[charleslales]

Yep, can understand.. and make sens of course. What doesn't is when external governance constraints you to play with (suffer of) IE8..

Another question: is there a reason / restriction for not using jQueryUI? e.g. portlets or even modal forms for editiing..? https://jqueryui.com/sortable/#portlets http://jqueryui.com/dialog/#modal-form

Kind regards, Charles

[cgaspard]

Hi @charleslales ,

At one time I did have modal dialog forms, but decided to remove them because I wanted a slightly different look.

As for the portlets, I haven't really ever played with those. I choose to build my own UI for the cards so that I could get exactly the look I wanted.

Thanks for the suggestions for IE8 support. Were you ever able to switch to IE9?

Corey