search

cgat-developers / cgat-apps

cgat-apps repository
Other
33 stars 14 forks source link

Deal with empty MEME files in MEME.py #65

Closed IanSudbery closed 4 years ago

IanSudbery commented 4 years ago

Contains checks to deal with empty MEME files, and py3 changes to deal with generators being created rather than lists.

IanSudbery commented 4 years ago

Don't undertand why checks are failing?

Acribbs commented 4 years ago

Ah I think this may be due to the way travis has changed its directory system. I have seen this error before I just can’t remember where or when. Will have a think tonight and see if I can remember.

Acribbs commented 4 years ago

I fixed the master branch with new Miniconda install. I then merged that into this branch. It seems like this branch was 138 commits behind the master. Not sure why its so behind? Anyway, I get the pull request passing but not the push. Will do the same with the other branch and see how it goes

Acribbs commented 4 years ago

Since the pr is passing I would have thought that it would be safe to merge

IanSudbery commented 4 years ago

The branches are behind master because we only update our master when we start a new project, but we need the bug fixes straight away.

Sorry I should have created a branch just for the PR and merged it with origin/master myself first.