search

cgat-developers / cgat-flow

cgat-flow repository
MIT License
13 stars 9 forks source link

Update install.sh #126

Closed sebastian-luna-valero closed 4 years ago

sebastian-luna-valero commented 4 years ago

Andreas created install.sh separated from install-devel.sh to have a script that installs cgat-flow from GitHub but using cgat-core and cgat-apps from conda, and simplifies the code in install-devel.sh. This PR makes minor amendments to install.sh

Acribbs commented 4 years ago

I didn't realise the specific differences between both of the install scripts. Is this documented? Maybe worth adding to the README?

sebastian-luna-valero commented 4 years ago

Hi Adam,

I have updated the readme accordingly and added a minor comment on the install.sh script.

Best regards, Sebastian

Acribbs commented 4 years ago

Sorry, I missed that, was looking at the code. Looks good! I tried the install-devel script yesterday and it failed with conflicts. Im going to do more testing when I have time to see if this is related to a specific package.

sebastian-luna-valero commented 4 years ago

Yes, I am aware of that error. Open a new issue and we can discuss it there tomorrow.