search

cgat-developers / cgat-flow

cgat-flow repository
MIT License
13 stars 9 forks source link

KRA: peakcalling yaml #65

Closed kevinrue closed 5 years ago

kevinrue commented 5 years ago

See

have_input, e.g. https://github.com/kevinrue/cgat-flow/blob/master/cgatpipelines/tools/pipeline_peakcalling.py#L350

use_input, e.g. https://github.com/kevinrue/cgat-flow/blob/master/cgatpipelines/tools/pipeline_peakcalling.py#L761

Acribbs commented 5 years ago

This looks good to me. Im going to look into why this isn't picked up on our testing.

jscaber commented 5 years ago

@AndreasHeger Why are there two different input variables? Is this intentional?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Adam Cribbs notifications@github.com Sent: Wednesday, October 3, 2018 5:25:36 PM To: cgat-developers/cgat-flow Cc: Subscribed Subject: Re: [cgat-developers/cgat-flow] KRA: peakcalling yaml (#65)

This looks good to me. Im going to look into why this isn't picked up on our testing.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/cgat-developers/cgat-flow/pull/65#issuecomment-426702485, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALmOstHGrcbjORd790EUwQ0Z_0NoiK5eks5uhOUAgaJpZM4XGXKY.

Acribbs commented 5 years ago

@jscaber from what I can see its probably because you may have inputs you would like to filter for general peak calling but you don't want to use them for IDR analysis because you want to assess your repeats independent of the inputs.