search

cgat-developers / cgat-flow

cgat-flow repository
MIT License
13 stars 9 forks source link

IX Indexer is Deprecated (pandas) #73

Closed kevinrue closed 5 years ago

kevinrue commented 5 years ago

I'm running into this error: http://pandas.pydata.org/pandas-docs/stable/indexing.html#ix-indexer-is-deprecated

Acribbs commented 5 years ago

I will run tests then merge tomorrow if they all pass, sorry its taken a while.

Acribbs commented 5 years ago

Hi @kevinrue , when I run pipeline tests, these files are missing test_exome.dir/variants/all_samples.annotated.vcf.idx,test_exome.dir/variants/all_samples.annotated.vcf

kevinrue commented 5 years ago

Eh... I don't see the link with my edits or even this pipeline for that matter... Perhaps I forked this branch before some test files were added for another pipeline, in which case there may be another branch somewhere that needs to be merged into this one? Perhaps git merge master KR-pandas-ix ?

Acribbs commented 5 years ago

yeh I agree, because all you have changed was the ipython notebook. I will pull and re-run tests

Acribbs commented 5 years ago

so with changes suggested by https://github.com/cgat-developers/cgat-core/pull/58. These changes now pass tests