cgcel / obsidian-local-backup

Automatically creates a local backup of the vault.
MIT License
33 stars 1 forks source link

[BUG] Save path isn't updating #14

Closed decaf-dev closed 7 months ago

decaf-dev commented 8 months ago

My save path isn't updating even though I have changed it. I looked in the data.json file created by the plugin settings and it looks like there's a bunch of duplicates.

I have it set to backups but it still saving in second_brain-backups

I had updated the config and did press "Apply && Save"

image image
decaf-dev commented 8 months ago

Here is the raw text if you want to try to use it

{
  "versionValue": "0.1.0",
  "startupBackupStatus": false,
  "lifecycleValue": "7",
  "backupsPerDayValue": "1",
  "winSavePathValue": "",
  "unixSavePathValue": "/Users/trey/Desktop/backups",
  "fileNameFormatValue": "second_brain-backup-%Y_%m_%d-%H_%M_%S",
  "intervalBackupStatus": false,
  "backupFrequencyValue": "10",
  "callingArchiverStatus": false,
  "archiverTypeValue": "sevenZip",
  "archiverPathValue": "",
  "startupSetting": false,
  "lifecycleSetting": "7",
  "backupsPerDaySetting": "1",
  "winSavePathSetting": "/Users/trey/Desktop/second_brain-backups",
  "unixSavePathSetting": "/Users/trey/Desktop/second_brain-backups",
  "customizeNameSetting": "second_brain-backup-%Y_%m_%d-%H_%M_%S",
  "intervalToggleSetting": true,
  "intervalValueSetting": "20",
  "sevenZipBackupToggleSetting": false,
  "sevenZipPathSetting": "",
  "savePathSetting": "/Users/trey/Desktop/second_brain-backups"
}
decaf-dev commented 8 months ago

In other Obsidian plugins, they don't use an "Apply && Save" button. The text is automatically saved upon any change to the text input. The Restore defaults button makes sense to me.

Would it be possible to remove the "Apply && Save" button and just save any changes?

cgcel commented 8 months ago

Yes you are right , the button will be removed in the next version.

decaf-dev commented 8 months ago

Sounds good. Thank you for the great plugin! It has given me more ease of mind with my second brain. I love the configuration options from inside Obsidian.

cgcel commented 8 months ago

Hi Trey, this bug has fixed and the Apply && Save button has been removed.