cgcel / obsidian-local-backup

Automatically creates a local backup of the vault.
MIT License
33 stars 1 forks source link

Obsidian hangs on Windows 10 #6

Closed merlinuwe closed 5 months ago

merlinuwe commented 8 months ago

Thanks for your plugin.

I installed it -> I reconfigured it to 0 and tried to restart Obsidian. -> Obsidian freezes. -> I deleted the folder with your plugin -> Obsidian starts.

cgcel commented 8 months ago

Thanks for your reporting... Maybe I should add a limit in setting page to avoid these bugs.

cgcel commented 8 months ago

This issue bas been fixed in 0.0.7, users can't set Backup Intervals to 0 from this version on.

merlinuwe commented 8 months ago

Thank you very much.

I have downloaded the plugin and installed it again. These are my settings:

image

After "apply settings" it freezes nonetheless. Stopping obsidian and starting again lets obsidian stop here:

image

My backup-folder "Obsidian.backups" is empty, even after a few minutes.

[after some time ...]

The backup is ready,

image

but Obsidian is still freezing.

cgcel commented 8 months ago

Thank you very much.

I have downloaded the plugin and installed it again. These are my settings:

image

After "apply settings" it freezes nonetheless. Stopping obsidian and starting again lets obsidian stop here:

image

My backup-folder "Obsidian.backups" is empty, even after a few minutes.

Thanks for your testing, may I ask how big is your vault? If you own a big vault, the plugin will cause a lag, pls share your vault size with me and I will try again at my computer.

merlinuwe commented 8 months ago

I added the file size (~ 1.7 GB) a few minutes after posting as a screenshot.

cgcel commented 8 months ago

I added the file size (~ 1.7 GB) a few minutes after posting as a screenshot.

Got it, maybe you should close the interval backup or set a bigger interval, like 30 at this version, this plugin is not ready for a big vault size like yours😂, but I plan to do the backup in a thread to avoid these lags, so pls look forward to the coming version.

cgcel commented 8 months ago

I'm afraid I can't run the backup on another thread, obsidian throws exception when I called workder_thread:

Error: The V8 platform used by this instance of Node does not support creating Workers.

So this issue would be closed. Thank you for using my plugin, I suggest you to setup this plugin like above's.

cgcel commented 8 months ago

Hi, 0.0.9 released, you can try the experimental feature, Backup by 7-Zip, if toggled, backups will be created by calling 7zip, and obsidian won't stuck any more.

merlinuwe commented 8 months ago

Thank you very much. With these settings:

image

the first file is made:

image

I get an error message

image

but the backup seems to be complete

image

A big step forward. ;-)

Some questions:

Is it possible to optionally save the backup in .7z format and give it a password?

Is it possible to exit Obsidian while the backup is running without leaving the backup you started in an undefined or incomplete state?

Once completed, how does the user know that the files are fully backed up?

cgcel commented 8 months ago

Thank you very much. With these settings:

image

the first file is made:

image

I get an error message

image

but the backup seems to be complete

image

A big step forward. ;-)

Some questions:

Is it possible to optionally save the backup in .7z format and give it a password?

Is it possible to exit Obsidian while the backup is running without leaving the backup you started in an undefined or incomplete state?

Once completed, how does the user know that the files are fully backed up?

Hello, after my testing:

I created a 3.6GB vault and I can't reproduce your error during the backup mission.

mswdev commented 8 months ago

@cgcel

Hi, 0.0.9 released, you can try the experimental feature, Backup by 7-Zip, if toggled, backups will be created by calling 7zip, and obsidian won't stuck any more.

If this is the best route to fix the backups hanging the UI thread, could you add support for Winrar too?

cgcel commented 8 months ago

@cgcel

Hi, 0.0.9 released, you can try the experimental feature, Backup by 7-Zip, if toggled, backups will be created by calling 7zip, and obsidian won't stuck any more.

If this is the best route to fix the backups hanging the UI thread, could you add support for Winrar too?

Yes, winrar will be supported in the next version if 7-zip mode works well, up to now I havn't found any issues yet.

mswdev commented 8 months ago

Awesome, thank you!

[data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACwAAAAAAQABAAACAkQBADs=3D] On Wed, Nov 1, 2023 at 12:28 AM GC Chen @.***> wrote:

@cgcel [https://github.com/cgcel]

Hi, 0.0.9 released, you can try the experimental feature, Backup by 7-Zip, if toggled, backups will be created by calling 7zip, and obsidian won't stuck any more.

If this is the best route to fix the backups hanging the UI thread, could you add support for Winrar too?

Yes, winrar will be supported in the next version if 7-zip mode works well, up to now I havn't found any issues yet.

— Reply to this email directly, view it on GitHub [https://github.com/cgcel/obsidian-local-backup/issues/6#issuecomment-1788479720], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ACWQ7SZG5KG652DIFZ3SPBTYCHTYTAVCNFSM6AAAAAA6LTN7JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGQ3TSNZSGA]. You are receiving this because you commented.[https://ci6.googleusercontent.com/proxy/Isj0c9zsHDwSsc7Xz04YCp9pMZlhsqu5f14WWMQr_O4b-6auWU4Nms0lUn_q4xrXc8Dji6TOela1mpC661VGpqNegXGoUjjPekpXBY_pN1bIAfXov_zOU_shD-hjhQpKm4Gb-k95u6-vX__dw4Tq2llTKEL04LHC6TBUS_shcEolSi8FdcyeUBXbxruOX4Is4b7emaaLoUIK_OdSA3kG2s8lgCMakZFHbRxMOnnSR7udgZxYag=s0-d-e1-ft#https://github.com/notifications/beacon/ACWQ7S47IQJJZFRGZELOLLDYCHTYTA5CNFSM6AAAAAA6LTN7JSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTKTIEOQ.gif]Message ID: @.***>

cgcel commented 8 months ago

Awesome, thank you! [data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACwAAAAAAQABAAACAkQBADs=3D] … On Wed, Nov 1, 2023 at 12:28 AM GC Chen @.> wrote: > @cgcel [https://github.com/cgcel] > > > Hi, 0.0.9 released, you can try the experimental feature, Backup by 7-Zip, > > if toggled, backups will be created by calling 7zip, and obsidian won't > > stuck any more. > > If this is the best route to fix the backups hanging the UI thread, could > you add support for Winrar too? Yes, winrar will be supported in the next version if 7-zip mode works well, up to now I havn't found any issues yet. — Reply to this email directly, view it on GitHub [#6 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ACWQ7SZG5KG652DIFZ3SPBTYCHTYTAVCNFSM6AAAAAA6LTN7JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGQ3TSNZSGA]. You are receiving this because you commented.[https://ci6.googleusercontent.com/proxy/Isj0c9zsHDwSsc7Xz04YCp9pMZlhsqu5f14WWMQr_O4b-6auWU4Nms0lUn_q4xrXc8Dji6TOela1mpC661VGpqNegXGoUjjPekpXBY_pN1bIAfXov_zOU_shD-hjhQpKm4Gb-k95u6-vX__dw4Tq2llTKEL04LHC6TBUS_shcEolSi8FdcyeUBXbxruOX4Is4b7emaaLoUIK_OdSA3kG2s8lgCMakZFHbRxMOnnSR7udgZxYag=s0-d-e1-ft#https://github.com/notifications/beacon/ACWQ7S47IQJJZFRGZELOLLDYCHTYTA5CNFSM6AAAAAA6LTN7JSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTKTIEOQ.gif]Message ID: @.>

WinRAR has been supported in 0.1.1.

merlinuwe commented 8 months ago

@cgcel

Hi, 0.0.9 released, you can try the experimental feature, Backup by 7-Zip, if toggled, backups will be created by calling 7zip, and obsidian won't stuck any more.

If this is the best route to fix the backups hanging the UI thread, could you add support for Winrar too?

Yes, winrar will be supported in the next version if 7-zip mode works well, up to now I havn't found any issues yet.

I was able to make the first update in 7z format with release 0.1.1, thank you very much! ;-)

image

If I exit Obsidian while the backup runs and start it again, it seems to be that 2 backups are running:

image

Is it possible to start an other backup only, when the first backup is completely finished?

cgcel commented 8 months ago

If I exit Obsidian while the backup runs and start it again, it seems to be that 2 backups are running:

This is normal, if you close Obsidian while backing up, one 7-Zip Console still working at background, then if you open Obsidian during this thread working, the new 7-Zip Console thread will start. And the first 7-Zip Console ended when the backup mission created before you closed Obsidian finished, then the new backup task will start base on backup frequency in the setting page.

1699580556213

image

Is it possible to start an other backup only, when the first backup is completely finished?

I think it doesn't need any changes, we don't close and open Obsidian frequently, And keep the last backup task is important, which makes a backup with latest data.