fixes bug in `Reference.plate_maps`

cgevans / mixes

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

fixes bug in `Reference.plate_maps` #15

Closed dave-doty closed 2 years ago

dave-doty commented 2 years ago

This fixes a bug in Reference.plate_map where the Strand and PlateMap objects were not properly imported.

To avoid a circular import error at the submodule level, I had to put the imports inside the plate_maps method.

cgevans commented 2 years ago

The circular imports can be avoided by if TYPE_CHECKING:, as Reference is only used in the other files in that form. I'll pull my fixes from the experiment branch.

cgevans commented 2 years ago

This should be fixed in main now; it's odd that it wasn't caught by the tests, though.