cgevans / mixes

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

closes #22: added `split_mix` function for splitting a single large mix into several smaller mixes #23

Closed dave-doty closed 1 year ago

dave-doty commented 1 year ago

Closes #22

Sorry, the name of this branch is misleading. I decided only to implement mix splitting in this branch, and will handle the master mix issue separately.

codecov-commenter commented 1 year ago

Codecov Report

Merging #23 (728d5a0) into main (07f28ed) will increase coverage by 0.67%. The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   73.16%   73.84%   +0.67%     
==========================================
  Files          14       14              
  Lines        1994     2011      +17     
==========================================
+ Hits         1459     1485      +26     
+ Misses        535      526       -9     
Impacted Files Coverage Δ
src/alhambra_mixes/__init__.py 100.00% <ø> (ø)
src/alhambra_mixes/mixes.py 66.58% <75.00%> (-0.26%) :arrow_down:
src/alhambra_mixes/actions.py 85.62% <100.00%> (+0.09%) :arrow_up:
src/alhambra_mixes/components.py 89.37% <0.00%> (ø)
src/alhambra_mixes/references.py 66.02% <0.00%> (ø)
src/alhambra_mixes/experiments.py 100.00% <0.00%> (ø)
src/alhambra_mixes/units.py 88.18% <0.00%> (+13.41%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dave-doty commented 1 year ago

Not sure what you want to do about the strange mypy errors. Besides those, I think this PR is ready to merge.

cgevans commented 1 year ago

That is fortunate timing, as I'm just at a point where I can look at this: I'll see if I can figure out what is causing them.