search

cgevans / mixes

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Type fixes for Pint >= 0.19.3 and attrs fixes for Python 3.11. #25

Closed cgevans closed 1 year ago

cgevans commented 1 year ago

See:

https://github.com/python-attrs/attrs/pull/969 https://github.com/hgrecco/pint/issues/1642

codecov-commenter commented 1 year ago

Codecov Report

Merging #25 (bf9d192) into main (07f28ed) will increase coverage by 0.74%. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   73.16%   73.91%   +0.74%     
==========================================
  Files          14       14              
  Lines        1994     1997       +3     
==========================================
+ Hits         1459     1476      +17     
+ Misses        535      521      -14
Impacted Files Coverage Δ
src/alhambra_mixes/mixes.py 66.84% <ø> (ø)
src/alhambra_mixes/actions.py 85.52% <50.00%> (ø)
src/alhambra_mixes/components.py 89.37% <100.00%> (ø)
src/alhambra_mixes/dictstructure.py 61.53% <100.00%> (ø)
src/alhambra_mixes/experiments.py 100.00% <100.00%> (ø)
src/alhambra_mixes/printing.py 60.58% <100.00%> (ø)
src/alhambra_mixes/quantitate.py 53.97% <100.00%> (ø)
src/alhambra_mixes/references.py 66.02% <100.00%> (ø)
src/alhambra_mixes/units.py 88.18% <100.00%> (+13.41%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dave-doty commented 1 year ago

I actually can't find documentation for PlainQuantity in pint. What is it? Do you have a link to a description of it?

dave-doty commented 1 year ago

I actually can't find documentation for PlainQuantity in pint. What is it? Do you have a link to a description of it?

In general the pint API seems incomplete: https://pint.readthedocs.io/en/stable/api/specific.html

For instance, there's another module pint.testing, but I don't see it mentioned in the link above.

Is that site out of date and their real documentation is elsewhere?

cgevans commented 1 year ago

This is confusing overall. After discussion on the pint issue, I've mostly switched back to Quantity instead of PlainQuantity, except where it is actually needed for mypy to stop complaining. PlainQuantity appears to be a new addition that isn't supposed to usually be necessary, but in adding it, the generic for the magnitude type for Quantity was removed. I'm hoping that will be added back at some point.