search

cgewecke / eth-gas-reporter

Gas usage per unit test. Average gas usage per method. A mocha reporter.
MIT License
603 stars 94 forks source link

Wrap codechecks server calls in try/catch blocks #168

Closed cgewecke closed 5 years ago

cgewecke commented 5 years ago

See gnosis-hg 58,

Travis error log

cgewecke commented 5 years ago

@krzkaczor Hi:)

gnosis/conditional-token-contracts is using codechecks w/ gas-reporter and getting a 500 server error (on the .success step I think). Can you see anything in the server logs on your side about this?

3.87s$ npx codechecks
CodeChecks Client v.0.1.5
https://codechecks.io
Executing 1 codechecks files
Base branch: d7ba7a2f
Executing codechecks.yml...
Error occured:  500 - {"statusCode":500,"message":"Internal server error"}

It possible I broke something here but am getting normal results in all my tests ... e.g have added codechecks to CI and get a report w/out problems

krzkaczor commented 5 years ago

Hey! I am on it. Generally, it's related to the fact that once in a while GitHub API is not accessible.

I hope that today I will come up with good error handling/retry strategy. I will keep you posted.

cgewecke commented 5 years ago

@krzkaczor Ah cool! Thanks!

krzkaczor commented 5 years ago

I just pushed the fix (and improved logging ;)) to production. Could you let me know if it helps @cgewecke

cgewecke commented 5 years ago

Yes I will, thanks so much @krzkaczor!

Closing here because resolved by #170 / 0.2.9

cgewecke commented 5 years ago

@krzkaczor In the end gnosis's problem might be that they renamed their repo. Idk, anyway it works again now after turning project on/off in the codechecks UI.

Thanks again for looking into this...

krzkaczor commented 5 years ago

@cgewecke fyi: i deployed multiple stability fixes over the weekend — random 500s should be gone now.

cgewecke commented 5 years ago

Thanks @krzkaczor!