search

cgewecke / eth-gas-reporter

Gas usage per unit test. Average gas usage per method. A mocha reporter.
MIT License
603 stars 94 forks source link

Switch to ethereum-cryptography #285

Closed frangio closed 2 years ago

frangio commented 2 years ago

This package is currently using an old version of ethereumjs-util (v6 while latest is v7). This version has the downside that it uses native dependencies, which is no longer necessary with modern libraries.

This PR replaces ethereumjs-util with ethereum-cryptography.

Am I supposed to include an updated version of the mock directory?

cgewecke commented 2 years ago

Am I supposed to include an updated version of the mock directory?

@frangio No don't worry about that. Thanks so much for this.

cgewecke commented 2 years ago

@frangio You don't have other PRs you're sending here today do you? If not I will publish.

frangio commented 2 years ago

No, unless you have another suggestion for a similar change. I noticed there is also a sha1 dependency but this hash function isn't covered by ethereum-cryptography.

cgewecke commented 2 years ago

It looks to me like sha1 is pure js.... I think this PR is sufficient and will be a big improvement.