Update deprecated packages

cgewecke / eth-gas-reporter

Gas usage per unit test. Average gas usage per method. A mocha reporter.

MIT License

603 stars 94 forks source link

Update deprecated packages #294

Closed ChristopherDedominici closed 1 year ago

ChristopherDedominici commented 1 year ago

Update deprecated packages:

ethers
mocha

Remove deprecated packages:

request
request-promise-native

cgewecke commented 1 year ago

@ChristopherDedominici Sorry for a pre-emptive review ... I think this might be a bit tricky. The package is super old.

Maybe PR could be split into a few pieces

make changes for newer ethers
do something about request
~~bump mocha~~

I'm happy to do the first two, ~~would you like to just make this one a mocha bump?~~

frangio commented 1 year ago

See https://github.com/cgewecke/eth-gas-reporter/pull/295

cgewecke commented 1 year ago

@ChristopherDedominici If you are continuing with this it will be necessary to rebase against master to get the tests running. The repo was not working with more recent versions of Node.

@frangio Updated mocha in #295 (merged)

ChristopherDedominici commented 1 year ago

@cgewecke I split this PR into smaller ones:

bump ethers version: https://github.com/cgewecke/eth-gas-reporter/pull/296
request: it seems that the request package is not used, it should be removed: https://github.com/cgewecke/eth-gas-reporter/pull/297
request-promise-native: https://github.com/cgewecke/eth-gas-reporter/pull/298

cgewecke commented 1 year ago

Closing via #299, #297, #296, #295