search

cgiffard / Downsize

Tag safe text truncation for HTML and XML!
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Rounding reverts #24

Closed adam-zethraeus closed 10 years ago

adam-zethraeus commented 10 years ago

As discussed at https://github.com/cgiffard/Downsize/issues/23, and since it's been a few days.

Please take a look at the context, @cgiffard @remy.

(Once this is in i'm going to redo the contexttualtags ghost PR, since it's unblocked now)

remy commented 10 years ago

:thumbsup:

cgiffard commented 10 years ago

I'm cool for you to merge as long as we can keep round:true or a similarly simple flag. I liked that. :)

adam-zethraeus commented 10 years ago

I'll add that to this PR before merge. Thanks guys.

cgiffard commented 10 years ago

No, I'm really sorry I didn't do due diligence before merging! I wasted you guys' time — apologies for that. I'll make sure I'm doing a more thorough code review in future.

adam-zethraeus commented 10 years ago

also, props to @remy for pushing downsize in a good direction :) (you should stick around here if there's other stuff you'd like to help improve!)

adam-zethraeus commented 10 years ago

https://github.com/cgiffard/Downsize/issues/25