cgilly2fast / DevelopX

A light weight local peer-to-peer git hosting client.
0 stars 1 forks source link

Wrapper git server In Express #5

Open cgilly2fast opened 4 years ago

cgilly2fast commented 4 years ago

This integration will wrap our node-git-server in an express server with CORS integration.

Located: gitServer/index.js

The server is intended to be run locally on a computer for users to push too.

See this comment in an issue in node-git server as a starting point. It lays out the basic structure of a node-git-server being used with express.

Outcome

**Work on branch: express-ts-git-server

See as Reference Node-git-server: Documentation Source Code

reo4 commented 4 years ago

i tried the solution in the comment and i searched a lot about running two apps on the same port but i didn't find any solution

seconed and forth requirements done , it remains the third one

reo4 commented 4 years ago

access denied to make push

cgilly2fast commented 4 years ago

I am going to move "Remove redundancy with 2 running servers into one." to a different issue.

Right now there is a server located in endpoints/index.ts and another server in gitServer/index.js

Ultimately we want these to be one file. endpoints/index.ts needs to be completely redone because it is based off of Firestore and EOS. So lets update these files separately then integrate them together.

If we collapse them now we will run into a lot of extra bugs.

Regarding push access, sense this project intended to be an open-source project, to make a contribution, fork the project, make all edits/commits on the fork, Then when it's done, create a pull request to merge your changes with the master project.

The fork, will allow you to work fast and allow me to view the code before it gets added to the main project.

Here is a video that goes over the process, you can skip the middle part where his explaining the git commands.

cgilly2fast commented 4 years ago

Here is link to some an issue thread that may be helpful.

reo4 commented 4 years ago

i will try this : https://www.npmjs.com/package/express-git tell me your opinion ?

cgilly2fast commented 4 years ago

I will look into it.

Please add CORS, you can see an example if needed in endpoints/index.ts

I just added reading the user name and password from the command line to the outcomes.

If we can achieve outcome 3 then we can probably just use nodejs readline() for completing outcome 4 .

Open to whatever makes sense.

https://nodejs.org/api/readline.html.