search

cginternals / globjects

C++ library strictly wrapping OpenGL objects.
https://globjects.org
MIT License
538 stars 59 forks source link

Transitive dependencies (closes #238) #242

Closed scheibel closed 10 years ago

scheibel commented 10 years ago

Use and provide transitive dependencies.

Rely on glbinding with its includes and libraries, so that no OpenGL linking is required. Include GLFW and glbinding in own includes and libraries when using the globjects find script.

The only drawback is the GLFW find script, which is expected to exist in a location searched by cmake. Unfortunately, the cmake subdirectory of globjects isn't. I don't know if we should add the cmake directory if the find script from the project root is used and install the glfw find script for system-wide usage. Another possibility is to add a GLFW find script to either the cmake find script repository or the GLFW project directly. Opinions required.

scheibel commented 10 years ago

The reason that I rename GLOBJECTS_INCLUDE_DIR and others to GLOBEJCTS_CORE_INCLUDE_DIR (and others) is a cmake optimization that seems to watch the variables _INCLUDE_DIR and _LIBRARY and if both are set, the find script finalizes and the upcoming code isn't executed. Probably you can document the behavior for your machine here?