search

cginternals / globjects

C++ library strictly wrapping OpenGL objects.
https://globjects.org
MIT License
539 stars 58 forks source link

Bug in Texture::cubeMapImage #368

Closed scheibel closed 2 years ago

scheibel commented 6 years ago

In each implementation of Texture::cubeMapImage loads the first of all six cube map part into all cube map layers. I imagine users of cubeMapImage provide one cube map part for each layer (totalling to six).

dlyr commented 4 years ago

I confirm this bug, we actually load cubemaps images using raw opengl calls. It would be nice (and easy) to take an array of 6 data ptr to set the 6 images.

dlyr commented 2 years ago

I can do a PR that uses data[i] instead of data, if data is not nullptr. Is that ok ?

scheibel commented 2 years ago

Thanks for the offer, but I'll rather go with a function overload taking an array of 6 data pointers.