Add libeigen3 support - Githubissues

cginternals / globjects

C++ library strictly wrapping OpenGL objects.

https://globjects.org

MIT License

538 stars 59 forks source link

Add libeigen3 support #390

Closed scheibel closed 3 years ago

dlyr commented 5 years ago

As I state in #385 , we will test this version with our rendering engine and I will confirm if it works as expected. In the meantime, review are welcome.

dlyr commented 5 years ago

On our side this version is working, but nobody have time to test every setters ... so might be documented as so.

scheibel commented 5 years ago

Thanks for the update, I'll have a look at it.

dlyr commented 4 years ago

Any news for a possible merge ?

scheibel commented 4 years ago

Thanks for the update, I added another review on our eigen branch (https://github.com/cginternals/globjects/tree/eigen).

Just for documentation, this PR covers uniform value setters for libEigen vector and matrix types. Currently unimplemented variants:

Double precision data types
Lists (vectors) of vectors and matrix data types
Arrays of vectors and matrix data types

I think this current state is mergable.

dlyr commented 4 years ago

For the doc, I think I could add a description of the functionality of this PR, and a mention of what is supported. But I'm not sure where I should write it.

dlyr commented 4 years ago

Long time without feedback. Is the project still active ? Feel free to ask for help

dlyr commented 3 years ago

ping ?

scheibel commented 3 years ago

Thanks for the ping. I'll get a fresh overview on this PR right now and see if it's mergable. In the meantime, I want to thank you for your efforts.

scheibel commented 3 years ago

This is a large increase in lines of code for the code base and we'll have a bunch of paths that are not yet implemented. I'm willing to adapt this as it is now and leave the implementations for later, when someone actually needs them and will test them. Merging this now. I have a few smaller changes but I add them afterwards. Thanks again for this extension to globjects!

dlyr commented 3 years ago

You're welcome. We use this branch for a while without any flaws in Radium-Engine, but surely we do not cover all use cases.