search

cginternals / libzeug

deprecated: C++ sanctuary for small but powerful and frequently required, stand alone features.
MIT License
16 stars 13 forks source link

Property refactoring #126

Closed sbusch42 closed 9 years ago

sbusch42 commented 9 years ago

Refactor property and variant system. Include JSON parser.

scheibel commented 9 years ago

The color test isn't compiling and currently I'm not sure how to resolve the undefined functions:

libzeug/source/tests/reflectionzeug-test/Color_test.cpp: In member function ‘virtual void Color_test_FromStringShouldFail_Test::TestBody()’:
libzeug/source/tests/reflectionzeug-test/Color_test.cpp:24:5: error: ‘fromString’ is not a member of ‘reflectionzeug::Color’
     Color::fromString(hexString, &success);
     ^
libzeug/source/tests/reflectionzeug-test/Color_test.cpp: In member function ‘virtual void Color_test_FromStringWithoutAlphaShouldSucceed_Test::TestBody()’:
libzeug/source/tests/reflectionzeug-test/Color_test.cpp:35:24: error: ‘fromString’ is not a member of ‘reflectionzeug::Color’
     const auto color = Color::fromString(hexString, &success);
                        ^
libzeug/source/tests/reflectionzeug-test/Color_test.cpp: In member function ‘virtual void Color_test_FromStringWithAlphaShouldSucceed_Test::TestBody()’:
libzeug/source/tests/reflectionzeug-test/Color_test.cpp:47:24: error: ‘fromString’ is not a member of ‘reflectionzeug::Color’
     const auto color = Color::fromString(hexString, &success);
                        ^
libzeug/source/tests/reflectionzeug-test/Color_test.cpp: In member function ‘virtual void Color_test_AsHexForBlack_Test::TestBody()’:
libzeug/source/tests/reflectionzeug-test/Color_test.cpp:58:34: error: ‘const class reflectionzeug::Color’ has no member named ‘asHex’
     const auto hexString = color.asHex(false);
                                  ^
libzeug/source/tests/reflectionzeug-test/Color_test.cpp: In member function ‘virtual void Color_test_AsHexWithAlpha_Test::TestBody()’:
libzeug/source/tests/reflectionzeug-test/Color_test.cpp:68:34: error: ‘const class reflectionzeug::Color’ has no member named ‘asHex’
     const auto hexString = color.asHex(true);
sbusch42 commented 9 years ago

That functionality has been moved to the color property for now, but I already thought about moving it to utils and just calling it from the property (and maybe restoring it in the color class, then). I suggest to ignore (disable) the tests for now, thorough test code for the property system is already being worked on.