search

cginternals / libzeug

deprecated: C++ sanctuary for small but powerful and frequently required, stand alone features.
MIT License
16 stars 13 forks source link

Make Property... (PropertyString etc.) to templates #134

Closed lanice closed 9 years ago

lanice commented 9 years ago

This equalizes the implementation of supported Property types, and makes PropertyString, PropertyBool, PropertyColor, PropertyFilePath, to template classes.

This also adds std::string as datatype for Property instanciation testing.

cgcostume commented 9 years ago

Please remove REFLECTIONZEUG_API from PropertyFilePath, PropertyColor, PropertyString, and PropertyBool. With this change, libzeug compiles on windows - the latest commit 5a998f63c405f9267c34b9882cec902dac066124 is obsolete then, so we should revert before merge.

lanice commented 9 years ago

Reverted commit 5a998f6 and removed REFLECTIONZEUG_API from PropertyFilePath, PropertyColor, PropertyString, and PropertyBool. Compiles on Ubuntu 14.04 with gcc 4.8.

scheibel commented 9 years ago

Now we have two reverts of this commit. One in master and another in this branch... can you merge the libzeug master just to make sure nothing confusing happens?

lanice commented 9 years ago

Done.