search

cginternals / webgl-operate

A TypeScript based WebGL rendering framework.
https://webgl-operate.org
MIT License
166 stars 25 forks source link

gltf-loader-ts is not a dev-dependency, but a dependency #260

Closed anne-gropler closed 3 years ago

anne-gropler commented 3 years ago

I am not sure about how dev-dependencies are treated when webgl-operate is used as a library, but it seems that gltf-loader-ts is not a dev-dependency, but a real dependency. There are classes imported from it in file gltfloader.ts.

I use webgl-operate in a library A that is used in app B. When I compile library A (which has a direct dependency on webgl-operate), everything seems to be fine. However, when I compile and start the app B (depends on A, which depends on webgl-operate), then an Error is shown regarding gltf-loader-ts not being found.

It seems that declaring gltf-loader-ts as a dependency in package.json fixes this. But since I don't work with dependencies that much, there might be a better option?

anne-gropler commented 3 years ago

@p-otto I saw that you worked on the gltf loader. Do you know more about this issue?