search

cginternals / webgl-operate

A TypeScript based WebGL rendering framework.
https://webgl-operate.org
MIT License
166 stars 25 forks source link

declare gltf-loader-ts as dependency #261

Closed anne-gropler closed 3 years ago

anne-gropler commented 3 years ago

Closes #260 .

Let me know if you have other ideas.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 20.213% when pulling a1b68c21bef6ae022e57c91bb9f5804ee8034163 on 260-gltf-loader-ts-as-dep into fbf6d888e2a84291f9dc970fce4c50a2d2aa441c on master.

p-otto commented 3 years ago

It seems logical that it should be a "real" dependency. But the same is true for gl-matrix and probably others. @cgcostume Is there a reason for us to add everything as a dev dependency?

anne-gropler commented 3 years ago

@p-otto it seems that normally, with webpack we don't need "real" dependecies, see this article. However, something doesn't work here, so a long-term solution would be a different fix than adding a dependency.

anne-gropler commented 3 years ago

@scheibel Do you know why the continuous integration doesn't run and how I can debug this?