cgisca / PGSGP

Play Games Services plugin for Godot Game Engine - Android
MIT License
219 stars 60 forks source link

Get more account data #34

Closed PhilippGackstatter closed 4 years ago

PhilippGackstatter commented 4 years ago

First of all, thanks for this plugin!

I read over the official guide and when signing in a user, one can get a GoogleSignInAccount. It gives access to various information such as name, email, account_id, ...

In the plugin, it seems, I can only get access to the account_id that is passed to the _on_sign_in_success callback. Is it possible to get access to the other information as well or would this require rewriting parts of the plugin?

Thanks!

cgisca commented 4 years ago

Hi @PhilippGackstatter , Unfortunately at the moment plugin does not support this functionality.I will add it for the next release. When it will be ready I will let you know in this thread.

Thank you

tytkal commented 4 years ago

Hi @cgisca Thanks for the amazing plugin I already update the project to support more data, I want to push the changes into new branch but i don't have the permission to do it. Thanks.

cgisca commented 4 years ago

Thank you @tytkal, please open a pull request and I will review it. thanks

tytkal commented 4 years ago

@cgisca Done https://github.com/cgisca/PGSGP/pull/35

cgisca commented 4 years ago

@PhilippGackstatter please check the new release for the Profile info functionality. See Player Info section in Readme.md .You'll get info like name, title, display name, player id, image url, banner image url, level info. The only piece of info that is missing is email address, but I will add that when I will implement the next feature, which is Friends beta.

PhilippGackstatter commented 4 years ago

That's perfect, thanks for adding this so quickly! Much appreciated :pray: