search

cgkineo / adapt-devtools

Tools for developing and testing Adapt courses
GNU General Public License v3.0
8 stars 6 forks source link

compatibility with Adapt FW v5.8.0 #48

Closed moloko closed 3 years ago

moloko commented 3 years ago

The new 'rollup' module bundler in Adapt v5.8.0 is not happy with this extension! I think it's either the references to coreJS or the old define(function(require){}) module definitions

oliverfoster commented 3 years ago

Both should be fine. coreJS definitely still gets mapped. More likely the commonjs style definitions are causing issue. I'll try to fix in adapt and let you know.

chris-steele commented 3 years ago

My first impression is just that there are loads of require() calls (like this one). Is there any function mapping now that require has been dropped?

oliverfoster commented 3 years ago

Yes, but it's not working correctly. It's leaving var ; in place where it shouldn't.

oliverfoster commented 3 years ago

Try this: https://github.com/adaptlearning/adapt_framework/pull/2998

moloko commented 3 years ago

FW v5.8.1 fixes this issue - but now I can get past that I'm getting a different issue! See #49