search

cgkineo / adapt-devtools

Tools for developing and testing Adapt courses
GNU General Public License v3.0
8 stars 6 forks source link

"Complete page" button not accounting for items #89

Closed swashbuck closed 5 months ago

swashbuck commented 5 months ago

Subject of the issue

In https://github.com/adaptlearning/adapt-contrib-pageLevelProgress/pull/221, the progress of presentation components with items are shown incrementally. That is, if 1 of 3 Narrative stages are completed, the PLP progress bar for the component will be 33% full.

This is breaking the "Complete page" option in Dev Tools. Presentation components with items are not shown in the PLP drawer as being fully completed. However, it does appear that the overall page is marked as completed.

Your environment

Steps to reproduce

  1. In the vanilla p101 build, go to Presentation Components
  2. Open the Dev Tools drawer and select "Complete page"

Result

Components with items (e.g. Narrative) are shown as partially complete.

PLP
oliverfoster commented 5 months ago

Can you fix this in plp please?

It should be 100 if the component is complete and otherwise return the items calculation. That's my fault. Apologies.

https://github.com/adaptlearning/adapt-contrib-pageLevelProgress/blob/a0941e0277f67c6d801db07c57f4b9ca3dae2017/js/PageLevelProgressIndicatorView.js#L57

swashbuck commented 5 months ago

Can you fix this in plp please?

Created https://github.com/adaptlearning/adapt-contrib-pageLevelProgress/issues/228