cgkineo / adapt-pageNav

Navigation bar component (quicknav clone)
GNU General Public License v3.0
6 stars 4 forks source link

Unnecessary status text applied to button elements #30

Closed joe-replin closed 2 years ago

joe-replin commented 2 years ago

Bug Description:

The controls to return to the main menu and proceed to the next/previous topic after completing a lesson, contain unnecessary status text "Incomplete" in their labels.

Steps to Reproduce:

Using a screen reader,open the course prototype. Open the standard experience, then complete all required questions. At the end of the lesson, focus on the main menu and next controls and note their labels.

Actual Behavior:

<button class="btn-icon pagenavbtn has-icon icon-is-left js-pagenav-btn" role="link" data-type="_root" data-id="course" data-item-index="1" aria-label="Go to main menu Incomplete" tooltip="">

<button class="btn-icon pagenavbtn has-icon icon-is-right js-pagenav-btn" role="link" data-type="_next" data-id="co-200" data-item-index="2" aria-label="Next Page Incomplete" tooltip="">

Expected Behavior:

Remove the unnecessary status text from the main menu/next controls. @oliverfoster, you may remember we gained alignment on this a few weeks back. Learners will know the status of a menu/page when they reach it.

image