search

cgkineo / adapt-pageNav

Navigation bar component (quicknav clone)
GNU General Public License v3.0
6 stars 4 forks source link

Fix: Add support for authoring tool 1 (fixes #39) #40

Closed joe-replin closed 1 year ago

joe-replin commented 1 year ago

Fixes: #39

Fix

joe-replin commented 1 year ago

Note: Unable to test this at this time. More to follow.

joe-replin commented 1 year ago

Tested in the AAT environment. Schemas ready to go.

swashbuck commented 1 year ago

Looks good. Some suggestions for tooltips (feel free to reword):

Icon class Show a tooltip with suggested icon and/or use the instructions from the readme? Ideally, include the Wiki URL somehow ( https://github.com/adaptlearning/adapt-contrib-vanilla/wiki/Icons ) but you can't click on links within a tooltip.

CSS class name to be applied to the button icon. Suggested: icon-home

_alignIconright Add tooltip like "Defines whether the icon is aligned to the left or right of the text."

Text for each button Maybe rename this to "Button text"? Then, mention in a tooltip that it's optional and you can only use an icon if that's your jam.

Override the route id Add a tooltip.

"Overrides the route ID. For use when non standard route navigation is required."

These are the instructions from the readme, but I think it could be dumbed down for non-devs. For instance, mention that it should correspond to a page's Friendly id (I assume that's the case).

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.1.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: