Closed swashbuck closed 6 months ago
@guywillis @oliverfoster I would like to work on this ticket. Before I get too deep into it, I would like to get your input first, mainly on the config interface decluttering.
Did either of you have specific things in mind that could be improved? Some suggestions I have:
_iconAlignment
with options for left, right, and auto (detects if using RTL or LTR). Defaults to "auto".
b. Alternatively, we could remove this option and base the position on RTL/LTR and the type of button (ex. previous or next). We would almost always want the previous button's icon to be left-aligned (or right-aligned for RTL), so not sure that we need to expose it as an option._iconClass
since we recommend no icon?_loopStyle
- Still needed?_iconClass
? Or is _iconClass
enough?_closeViaLMSFinish
and _notifyPromptIfIncomplete
options?Happy to set up a meeting to discuss. Thanks!
4b. It's difficult to map the number of siblings to the number of override text labels as "siblings" is just an abstract undefined number thereof, unless the override for page nav text labels lives on the sibling as a page nav specific alternative title, which is very messy - also not sure if useful
@oliverfoster The only use case I can think of would be to add a pound sign before each number. However, that doesn't really add much value imo. I would be in favor of removing the text
option for sibling buttons altogether.
#{{inc index}}
I'm at a stopping point with PR #49 until we resolve the questions above.
- Yes, make it consistent with adapt-close
I've moved this one to #50
:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Subject of the issue
The Page Nav plugin codebase needs to be updated / modernized. This would include:
In addition, it has been mentioned that there is too many config options and that the plugin config could be streamlined. Look into decluttering the interface / setup.