search

cgkineo / adapt-pageNav

Navigation bar component (quicknav clone)
GNU General Public License v3.0
6 stars 4 forks source link

Duplicate aria-label #60

Closed zubairslamdien closed 7 months ago

zubairslamdien commented 7 months ago

Aria label needs removing from template

The aria-label on the button container should be removed because it already gets one from the core ariaRegion div.

Screenshots (if you can)

image

oliverfoster commented 7 months ago

You could do it the other way round?

<nav></nav> is equivalent to <div role="navigation"></div>

Role navigation is a landmark role, so you'd be able to jump to it with accessibility shortcuts.

It makes sense that the nav tag has a label.

The top aria label can come from either here and here for handlebars or here for jsx. You can see that those functions are controlled with the model attribute _isA11yComponentDescriptionEnabled which defaults to true in componentModel.

Probably best to force the pageNav model to default to false for _isA11yComponentDescriptionEnabled instead of removing from the nav element?

github-actions[bot] commented 7 months ago

:tada: This issue has been resolved in version 3.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: