search

cgkineo / adapt-xAPI

An extension to utilise The Experience API (xAPI) to collect data on human performance, stored within a suitable Learning Record Store (LRS).
GNU General Public License v3.0
2 stars 1 forks source link

uglify compile error #18

Closed danielghost closed 6 months ago

danielghost commented 3 years ago

When compiling the build with a command that uglifies the files, fetch-polyfill causes an error due to the following code: https://github.com/cgkineo/adapt-xAPI/blob/master/libraries/fetch-polyfill.js#L459

This should be changed as follows:

var abortXhr = function() {
moloko commented 3 years ago

if you bump the FW to a more recent version, you might not need that polyfill?

danielghost commented 6 months ago

The compiling error is seemingly no longer an issue.

Whilst the polyfill is no longer needed for earlier browsers such as IE11 (which is no longer supported), it is still required as a fallback for Firefox which doesn't support the keepalive attribute, causing data sent on closing the browser to be potentially lost.