search

cgkineo / rub-cli

Adapt RUB buildkit
3 stars 2 forks source link

Fix for #22 #23

Closed chris-steele closed 5 years ago

chris-steele commented 5 years ago

Maybe naive, but tested working. Would appreciate your thoughts @oliverfoster as ever.

22

oliverfoster commented 5 years ago

Did you have an example schema in mind? bookmarking? https://github.com/adaptlearning/adapt-contrib-bookmarking/blob/master/properties.schema

oliverfoster commented 5 years ago

It appears to me that @moloko wanted the defaults from https://github.com/adaptlearning/adapt-contrib-bookmarking/blob/master/properties.schema#L14 to go into the course.json, config.json etc.

I can't see any modifications to the course / config.json?

chris-steele commented 5 years ago

Yeah this fix is just for what rub-cli does with globals. I haven't done anything for https://github.com/adaptlearning/adapt-cli/issues/94 yet (this will be something I do in adapt-cli)

oliverfoster commented 5 years ago

Do you have an example of a nested globals property? I'm struggling to find one.

chris-steele commented 5 years ago

Sure. Got an example from a bespoke version of spoor here: https://dev.kineo.com/svn/us-lcel-17186/trunk/dev/src/extensions/adapt-contrib-spoor/properties.schema - the _buttons property would be omitted without this change.