search

cgkineo / rub-cli

Adapt RUB buildkit
3 stars 2 forks source link

Regional language codes not importable #69

Closed joe-replin closed 2 days ago

joe-replin commented 7 months ago

The translate:import command doesn't import as intended if you are attempting to import a language code with a regional sub-language. It seems to be the - glyph that isn't accepted. You are able to import with a simpler language code and change your folder name post-import.

For example:

oliverfoster commented 7 months ago

Could you please paste the entire command or give a screenshot of the output? Which console are you using? mac, windows? Command prompt? Git bash?

Are the course\* folder names en-ca etc?

joe-replin commented 6 months ago

The command: translate:import --targetLang=fr-FR m05

A 'fr-FR' was placed in both course/ and languagefiles/

oliverfoster commented 6 months ago

Could be parameter parsing at this line https://github.com/cgkineo/rub-cli/blob/1c8161f29f5ed570fb9ed271b52f01b9242b5010/globals/terminal.js#L27

oliverfoster commented 6 months ago

image

Works fine here in git bash.

Which operating system and terminal are you using?

oliverfoster commented 6 months ago

you'd need to put the translation in the folder languagefiles/m05/fr-FR and not languagefiles/fr-FR which is the grunt version

oliverfoster commented 6 months ago

Did you have any luck or time in trying to replicate this? @joe-replin

joe-replin commented 6 days ago

I'm closing this due to inaction.

oliverfoster commented 5 days ago

Inaction? You haven't responded to any of my messages. 😭

joe-replin commented 2 days ago

Yes, it is my inaction. I am thinking your questions pointed to something I was doing wrong. I believe it is working as intended and see no issue. Feel free to keep this open just in case this exact configuration appears again with region codes.

oliverfoster commented 2 days ago

Cool. As long as you're satisfied. I'll close.