cglatot / PokeManager

Uses Python API for Pokemon Go to mass transfer Pokemon
Other
146 stars 31 forks source link

[Feature] Transfer duplicate pokemon should also use exceptions.config #36

Closed Necroskillz closed 8 years ago

Necroskillz commented 8 years ago

I could pull request if u want, but it's pretty simple change that should be easy enough to do for you.

fprovostpoulin commented 8 years ago

I'd like to have this change as well. It would also be nice to have a CP range as well for the dupplicate transfer. Maybe it could be a different exception file for the dupplicates. So I could (lets say) remove All duplicates under X CP and X IV except Pidgey, Caterpie and weedles. Thanks

cglatot commented 8 years ago

Solved with commit #40 by @bartonp

bartonp commented 8 years ago

@fprovostpoulin and @cglatot - I have the code for the CP limitation as a global input already. Do you want me to create another pull request or just add it into this one? It's located on this commit if you want to diff it -> https://github.com/bartonp/PokeManager/commit/80dd12f756803e38c8678c14ef55ce8e1cd47135

The separate file would have to be worked out into a different way as you could then have different levels per pokemon.

cglatot commented 8 years ago

I've added the CP cutoff - but I do not like the idea of the different files - I don't want this to be getting too complex. There are already so many options to make, I don't see the need for it.

fprovostpoulin commented 8 years ago

This is perfect asis ! Maybe adding a question for CP as you do for single transfer, that would be awesome.

Another thing that could be a nice option is to be able to transfer all the Non-starred or all of th Starred pokemon. What do you think ?

Thank you very much !

Félix Provost-Poulin

Software Engeneer Bacc. and MBA Candidate Cellulaire : (514) 463-1978

2016-08-02 17:54 GMT-04:00 cglatot notifications@github.com:

I've added the CP cutoff - but I do not like the idea of the different files - I don't want this to be getting too complex. There are already so many options to make, I don't see the need for it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cglatot/PokeManager/issues/36#issuecomment-237057662, or mute the thread https://github.com/notifications/unsubscribe-auth/ARHK37MQ3rZKfS8x5-sg8UzqdVBrzs1Lks5qb7yjgaJpZM4JZ9E2 .

cglatot commented 8 years ago

@fprovostpoulin - I've already added the CP cutoff - look at my last reply.

The transfer duplicates already won't transfer your starred pokemon. Not going to add a separate feature for it

fprovostpoulin commented 8 years ago

Okay; I didn't know it wasnt transfering starred pokemon; Maybe you could just put a note into your user guide :) Thanks

Félix Provost-Poulin

Software Engeneer Bacc. and MBA Candidate Cellulaire : (514) 463-1978

2016-08-03 1:28 GMT-04:00 cglatot notifications@github.com:

@fprovostpoulin https://github.com/fprovostpoulin - I've already added the CP cutoff - look at my last reply.

The transfer duplicates already won't transfer your starred pokemon. Not going to add a separate feature for it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cglatot/PokeManager/issues/36#issuecomment-237143769, or mute the thread https://github.com/notifications/unsubscribe-auth/ARHK36aoGudB4rm4Dg9jQ5johTwdb7qhks5qcCcKgaJpZM4JZ9E2 .