search

cglatot / PokeManager

Uses Python API for Pokemon Go to mass transfer Pokemon
Other
147 stars 32 forks source link

Count evolutions (does not account for second order evolutions yet) #7

Closed kvanderkamp closed 8 years ago

kvanderkamp commented 8 years ago

Players may use the number of possible evolutions to maximize XP gain from evolving Pokémon in combination with a Lucky Egg.

cglatot commented 8 years ago

A nice touch, but not fully thought-through from what I can see.

You only check if it can evolve - this means that your "countEvolutions" will be off because of the middle pokemon (E.G. Wartortle, etc). Since they share the same Candy as Squirtle, you will not be able to evolve both sets with the candies available, but the numbers will be added to "countEvolutions. If I'm reading your code wrong, please let me know.

Also, I think rolling this functionality into the current "Count" menu will be better than having a separate menu item for it.

kvanderkamp commented 8 years ago

Thank you for reviewing.

Middle Pokemon are not counted, I've set their candies to 0 in "countEvolutions". This means they are never counted, even if there are enough candies left over after all of the first Pokemon have evolved. Will be looking into that

When i've fixed counting the middle Pokemon and merged this functionality into the "view counts" menu I'll make another pull request.

kvanderkamp commented 8 years ago

I see you added the evolve counts in already, nice.

cglatot commented 8 years ago

Ahhhh I see it now, you removed some of the try-catches to facilitate that.

If you fork my latest commit, that has your logic in it for counts, but will count middle Pokemon.

The "total evolvable", I think, is more of a user expectation discussion rather than a technical one. I might add it as something like "Total evolutions of base pokemon" - in which case ignoring the second and third tier evolutions.

But I want to keep first and second tier "amounts to evolve" in the count view as I think it gives a good view in case you are looking to evolve certain pokemon (to get move sets, etc)

cglatot commented 8 years ago

Done. Shows total base evolutions available now :)