Activator incompatibility

[cgm616]

On occasion VolumeBar9 and Activator will crash the Springboard, I think because of the hook on VolumeControl.

Hard to test; hard to reproduce.

Log files:

• SpringBoard-2016-08-31-071058.symbolicated.ips.txt
• SpringBoard-2016-08-31-071058.syslog.txt

[cgm616]

Probably not a incompatibility? All the logs I've seen crash on -[VolumeBar resetTimer]

[cgm616]

Logs with activator uninstalled:

• SpringBoard-2016-08-31-212650.symbolicated.ips.txt
• SpringBoard-2016-08-31-212650.syslog.txt

This confirms that it's definitely something with only VolumeBar9.

[cgm616]

When adding logging to the tweak, the problem seems to disappear. Still hard to know for sure. Below is what was added.

VolumeBar.xm

-(void)resetTimer {
  HBLogDebug(@"in resetTimer");
  if(hide != nil) {
    HBLogDebug(@"hide exists");
    [hide invalidate];
    HBLogDebug(@"hide invalidated");
    hide = nil;
    HBLogDebug(@"hide = nil now");
    hide = [NSTimer scheduledTimerWithTimeInterval:_delayTime target:self selector:@selector(_hideHUD) userInfo:nil repeats:NO];
    HBLogDebug(@"new hide created");
  }
}

Tweak.xm

%hook VolumeControl

-(void)increaseVolume {
  HBLogDebug(@"hooked increaseVolume");
  if(active && vbar != nil) {
    HBLogDebug(@"calling resetTimer");
    [vbar resetTimer];
  }

  %orig;
}

%end

[cgm616]

One report has come in that the crash is actually from pressing the volume buttons and calling resetTimer while the banner is animating away.

[cgm616]

I was able to reproduce it in this way! Sweet, should be a relatively easy fix to disable any functionality of resetTimer after hideHUD has been called.