cgnorthcutt / benchmarking-keras-pytorch

🔥 Reproducibly benchmarking Keras and PyTorch models
https://l7.curtisnorthcutt.com/towards-reproducibility-benchmarking-keras-pytorch
Other
367 stars 43 forks source link

Use ==/!= to compare str, bytes, and int literals #6

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/cgnorthcutt/benchmarking-keras-pytorch on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./imagenet_pytorch_get_predictions.py:135:34: F632 use ==/!= to compare str, bytes, and int literals
    loader = dataloaders[299] if model_name is "inception_v3" else dataloaders[224]
                                 ^
1     F632 use ==/!= to compare str, bytes, and int literals
1

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

cgnorthcutt commented 5 years ago

This is reasonable. Thanks for the style suggestion. Migrating and closing.